Thanks for the reply, I removed the pump again today. The spring side smelt like it was covered with fuel. The metric X-ring that I had fitted has a larger ID than the shaft of the piston that is meant to seal against and is larger than the original X-ring, but once fitted into the housing it seems to seal OK, well I thought it was sealing OK. I have now sourced and fitted a SAE -011 X-ring. Ill see how this goes, otherwise I will refit the original X-ring.